Commit fff3e5ad authored Apr 14, 2011 by Milton Miller Committed by Linus Torvalds Apr 17, 2011

fs: synchronize_rcu when unregister_filesystem success not failure



While checking unregister_filesystem for saftey vs extra calls for
"ext4: register ext2 and ext3 alias after ext4" I realized that
the synchronize_rcu() was called on the error path but not on
the success path.

Cc: stable (2.6.38)
Signed-off-by: Milton Miller <miltonm@bga.com>
[ This probably won't really make a difference since commit d863b50a
  ("vfs: call rcu_barrier after ->kill_sb()"), but it's the right thing
  to do.  - Linus ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d733ed6c

fs/filesystems.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -110,14 +110,13 @@ int unregister_filesystem(struct file_system_type * fs)
		*tmp = fs->next;
		fs->next = NULL;
		write_unlock(&file_systems_lock);
		synchronize_rcu();
		return 0;
		}
		tmp = &(*tmp)->next;
		}
		write_unlock(&file_systems_lock);

		synchronize_rcu();

		return -EINVAL;
		}

Admin message