Commit fff1662c authored Sep 04, 2020 by Tobias Klauser Committed by Linus Torvalds Sep 05, 2020

ipc: adjust proc_ipc_sem_dointvec definition to match prototype

Commit 32927393 ("sysctl: pass kernel pointers to ->proc_handler")
changed ctl_table.proc_handler to take a kernel pointer. Adjust the
signature of proc_ipc_sem_dointvec to match ctl_table.proc_handler which
fixes the following sparse error/warning:

ipc/ipc_sysctl.c:94:47: warning: incorrect type in argument 3 (different address spaces)
ipc/ipc_sysctl.c:94:47: expected void *buffer
ipc/ipc_sysctl.c:94:47: got void [noderef] __user *buffer
ipc/ipc_sysctl.c:194:35: warning: incorrect type in initializer (incompatible argument 3 (different address spaces))
ipc/ipc_sysctl.c:194:35: expected int ( [usertype] *proc_handler )( ... )
ipc/ipc_sysctl.c:194:35: got int ( * )( ... )

Fixes: 32927393 ("sysctl: pass kernel pointers to ->proc_handler")
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Link: https://lkml.kernel.org/r/20200825105846.5193-1-tklauser@distanz.ch

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e80d3909

ipc/ipc_sysctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -85,7 +85,7 @@ static int proc_ipc_auto_msgmni(struct ctl_table *table, int write,
		}

		static int proc_ipc_sem_dointvec(struct ctl_table *table, int write,
		void __user buffer, size_t lenp, loff_t *ppos)
		void buffer, size_t lenp, loff_t *ppos)
		{
		int ret, semmni;
		struct ipc_namespace *ns = current->nsproxy->ipc_ns;

Admin message