Commit ffee202a authored Apr 06, 2020 by Sonny Sasaka Committed by Marcel Holtmann Apr 08, 2020

Bluetooth: Always request for user confirmation for Just Works (LE SC)



To improve security, always give the user-space daemon a chance to
accept or reject a Just Works pairing (LE). The daemon may decide to
auto-accept based on the user's intent.

This patch is similar to the previous patch but applies for LE Secure
Connections (SC).

Signed-off-by: Sonny Sasaka <sonnysasaka@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent fcd156ee

net/bluetooth/smp.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -2201,7 +2201,7 @@ mackey_and_ltk:
		if (err)
		return SMP_UNSPECIFIED;

		if (smp->method == JUST_WORKS \|\| smp->method == REQ_OOB) {
		if (smp->method == REQ_OOB) {
		if (hcon->out) {
		sc_dhkey_check(smp);
		SMP_ALLOW_CMD(smp, SMP_CMD_DHKEY_CHECK);
		@@ -2216,6 +2216,9 @@ mackey_and_ltk:
		confirm_hint = 0;

		confirm:
		if (smp->method == JUST_WORKS)
		confirm_hint = 1;

		err = mgmt_user_confirm_request(hcon->hdev, &hcon->dst, hcon->type,
		hcon->dst_type, passkey, confirm_hint);
		if (err)

Admin message