Commit ffecb0b4 authored May 11, 2018 by James Smart Committed by Christoph Hellwig May 25, 2018

nvme-fabrics: remove unnecessary controller subnqn validation



After creating the nvme controller, nvmf_create_ctrl() validates
the newly created subsysnqn vs the one specified by the options.

In general, this is an unnecessary check as the Connect message
should implicitly ensure this value matches.

With the change to the FC transport to do an asynchronous connect
for the first association create, the transport will return to
nvmf_create_ctrl() before that first association has been established,
thus the subnqn will not yet be set.

Remove the unnecessary validation.

Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 90fcaf5d

drivers/nvme/host/fabrics.c

+0 −10

Original line number	Diff line number	Diff line
		@@ -983,16 +983,6 @@ nvmf_create_ctrl(struct device dev, const char buf, size_t count)
		goto out_module_put;
		}

		if (strcmp(ctrl->subsys->subnqn, opts->subsysnqn)) {
		dev_warn(ctrl->device,
		"controller returned incorrect NQN: \"%s\".\n",
		ctrl->subsys->subnqn);
		module_put(ops->module);
		up_read(&nvmf_transports_rwsem);
		nvme_delete_ctrl_sync(ctrl);
		return ERR_PTR(-EINVAL);
		}

		module_put(ops->module);
		up_read(&nvmf_transports_rwsem);
		return ctrl;

Admin message