Commit ffe49823 authored Nov 05, 2018 by Chinh T Cao Committed by Jeff Kirsher Nov 07, 2018

ice: Change req_speeds to be u16



Since the req_speeds field in struct ice_link_status is a u8,
req_speeds & ICE_AQ_LINK_SPEED_40GB always returns 0. This was caught
by a coverity scan.

Fix this by changing req_speeds to be u16.

Reported-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Chinh T Cao <chinh.t.cao@intel.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 4c9b658e

drivers/net/ethernet/intel/ice/ice_type.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -92,12 +92,12 @@ struct ice_link_status {
		u64 phy_type_low;
		u16 max_frame_size;
		u16 link_speed;
		u16 req_speeds;
		u8 lse_ena; /* Link Status Event notification */
		u8 link_info;
		u8 an_info;
		u8 ext_info;
		u8 pacing;
		u8 req_speeds;
		/* Refer to #define from module_type[ICE_MODULE_TYPE_TOTAL_BYTE] of
		* ice_aqc_get_phy_caps structure
		*/

Admin message