Commit ffdd2018 authored by Miao Xie's avatar Miao Xie Committed by Chris Mason
Browse files

Btrfs: modify repair_io_failure and make it suit direct io 



The original code of repair_io_failure was just used for buffered read,
because it got some filesystem data from page structure, it is safe for
the page in the page cache. But when we do a direct read, the pages in bio
are not in the page cache, that is there is no filesystem data in the page
structure. In order to implement direct read data repair, we need modify
repair_io_failure and pass all filesystem data it need by function
parameters.

Signed-off-by: default avatarMiao Xie <miaox@cn.fujitsu.com>
Signed-off-by: default avatarChris Mason <clm@fb.com>
parent 2fe6303e

fs/btrfs/extent_io.c

+5 −3
Original line number Diff line number Diff line
@@ -1997,7 +1997,7 @@ static int free_io_failure(struct inode *inode, struct io_failure_record *rec) 
 */

int repair_io_failure(struct btrfs_fs_info *fs_info, u64 start,

			u64 length, u64 logical, struct page *page,

			int mirror_num)

			unsigned int pg_offset, int mirror_num)

{

	struct bio *bio;

	struct btrfs_device *dev;
@@ -2036,7 +2036,7 @@ int repair_io_failure(struct btrfs_fs_info *fs_info, u64 start, 
		return -EIO;

	}

	bio->bi_bdev = dev->bdev;

	bio_add_page(bio, page, length, start - page_offset(page));

	bio_add_page(bio, page, length, pg_offset);



	if (btrfsic_submit_bio_wait(WRITE_SYNC, bio)) {

		/* try to remap that extent elsewhere? */
@@ -2067,7 +2067,8 @@ int repair_eb_io_failure(struct btrfs_root *root, struct extent_buffer *eb, 
	for (i = 0; i < num_pages; i++) {

		struct page *p = extent_buffer_page(eb, i);

		ret = repair_io_failure(root->fs_info, start, PAGE_CACHE_SIZE,

					start, p, mirror_num);

					start, p, start - page_offset(p),

					mirror_num);

		if (ret)

			break;

		start += PAGE_CACHE_SIZE;
@@ -2127,6 +2128,7 @@ static int clean_io_failure(u64 start, struct page *page) 
		if (num_copies > 1)  {

			repair_io_failure(fs_info, start, failrec->len,

					  failrec->logical, page,

					  start - page_offset(page),

					  failrec->failed_mirror);

		}

	}

fs/btrfs/extent_io.h

+1 −1
Original line number Diff line number Diff line
@@ -340,7 +340,7 @@ struct btrfs_fs_info; 


int repair_io_failure(struct btrfs_fs_info *fs_info, u64 start,

			u64 length, u64 logical, struct page *page,

			int mirror_num);

			unsigned int pg_offset, int mirror_num);

int end_extent_writepage(struct page *page, int err, u64 start, u64 end);

int repair_eb_io_failure(struct btrfs_root *root, struct extent_buffer *eb,

			 int mirror_num);

fs/btrfs/scrub.c

+1 −0
Original line number Diff line number Diff line
@@ -682,6 +682,7 @@ static int scrub_fixup_readpage(u64 inum, u64 offset, u64 root, void *fixup_ctx) 
		fs_info = BTRFS_I(inode)->root->fs_info;

		ret = repair_io_failure(fs_info, offset, PAGE_SIZE,

					fixup->logical, page,

					offset - page_offset(page),

					fixup->mirror_num);

		unlock_page(page);

		corrected = !ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE