Commit ffda9d30 authored Feb 20, 2007 by Nick Piggin Committed by Linus Torvalds Feb 20, 2007

[PATCH] fs: fix __block_write_full_page error case buffer submission



Andrew noticed that unlocking the page before submitting all buffers for
writeout could cause problems if the IO completes before we've finished
messing around with the page buffers, and they subsequently get freed.

Even if there were no bug, it is a good idea to bring the error case
into line with the common case here.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent bc56bba8

fs/buffer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1743,7 +1743,6 @@ recover:
		SetPageError(page);
		BUG_ON(PageWriteback(page));
		set_page_writeback(page);
		unlock_page(page);
		do {
		struct buffer_head *next = bh->b_this_page;
		if (buffer_async_write(bh)) {
		@@ -1753,6 +1752,7 @@ recover:
		}
		bh = next;
		} while (bh != head);
		unlock_page(page);
		goto done;
		}

Admin message