Commit ffaec3b2 authored Feb 13, 2019 by Colin Ian King Committed by Mauro Carvalho Chehab Feb 18, 2019

media: exynos4-is: remove redundant check on type



The check to see if type is V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE is redundant
as this has been already checked at the start of the function and if
it's not that value then -ENOSYS is returned. Hence the sprintf can be
replaced by a simpler string copy.

Detected by CoverityScan, CID#1309450 ("Logically dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 8dd22b28

drivers/media/platform/exynos4-is/fimc-isp-video.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -606,9 +606,7 @@ int fimc_isp_video_device_register(struct fimc_isp *isp,

		vdev = &iv->ve.vdev;
		memset(vdev, 0, sizeof(*vdev));
		snprintf(vdev->name, sizeof(vdev->name), "fimc-is-isp.%s",
		type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE ?
		"capture" : "output");
		strscpy(vdev->name, "fimc-is-isp.capture", sizeof(vdev->name));
		vdev->queue = q;
		vdev->fops = &isp_video_fops;
		vdev->ioctl_ops = &isp_video_ioctl_ops;

Admin message