Commit ffa91880 authored Apr 18, 2014 by Adrien BAK Committed by Jiri Olsa Apr 20, 2014

perf tools: Improve error reporting

In the current version, when using perf record, if something goes
wrong in tools/perf/builtin-record.c:375
  session = perf_session__new(file, false, NULL);

The error message:
"Not enough memory for reading per file header"

is issued. This error message seems to be outdated and is not very
helpful. This patch proposes to replace this error message by
"Perf session creation failed"

I believe this issue has been brought to lkml:
https://lkml.org/lkml/2014/2/24/458


although this patch only tackles a (small) part of the issue.

Additionnaly, this patch improves error reporting in
tools/perf/util/data.c open_file_write.

Currently, if the call to open fails, the user is unaware of it.
This patch logs the error, before returning the error code to
the caller.

Reported-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Adrien BAK <adrien.bak@metascale.org>
Link: http://lkml.kernel.org/r/1397786443.3093.4.camel@beast


[ Reorganize the changelog into paragraphs ]
[ Added empty line after fd declaration in open_file_write ]
Signed-off-by: Jiri Olsa <jolsa@redhat.com>

parent 922d0e4d

tools/perf/builtin-record.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -374,7 +374,7 @@ static int __cmd_record(struct record rec, int argc, const char *argv)

		session = perf_session__new(file, false, NULL);
		if (session == NULL) {
		pr_err("Not enough memory for reading perf file header\n");
		pr_err("Perf session creation failed.\n");
		return -1;
		}

tools/perf/util/data.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -86,10 +86,17 @@ static int open_file_read(struct perf_data_file *file)

		static int open_file_write(struct perf_data_file *file)
		{
		int fd;

		if (check_backup(file))
		return -1;

		return open(file->path, O_CREAT\|O_RDWR\|O_TRUNC, S_IRUSR\|S_IWUSR);
		fd = open(file->path, O_CREAT\|O_RDWR\|O_TRUNC, S_IRUSR\|S_IWUSR);

		if (fd < 0)
		pr_err("failed to open %s : %s\n", file->path, strerror(errno));

		return fd;
		}

		static int open_file(struct perf_data_file *file)

Admin message