Commit ffa0aea6 authored May 01, 2005 by Paolo 'Blaisorblade' Giarrusso Committed by Linus Torvalds May 01, 2005

[PATCH] uml - hostfs: avoid buffers



Use this:
	.set_page_dirty = __set_page_dirty_nobuffers,

We already dropped the inclusion of <linux/buffer_head.h>, and we don't have a
backing block device for this FS.

"Without having looked at it, I'm sure that hostfs does not use buffer_heads.
So setting your ->set_page_dirty a_op to point at __set_page_dirty_nobuffers()
is a reasonable thing to do - it'll provide a slight speedup."

This speedup is one less spinlock held and one less conditional branch, which
isn't bad.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent b97b77cc

fs/hostfs/hostfs_kern.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -521,7 +521,7 @@ int hostfs_commit_write(struct file file, struct page page, unsigned from,
		static struct address_space_operations hostfs_aops = {
		.writepage = hostfs_writepage,
		.readpage = hostfs_readpage,
		/* .set_page_dirty = __set_page_dirty_nobuffers, */
		.set_page_dirty = __set_page_dirty_nobuffers,
		.prepare_write = hostfs_prepare_write,
		.commit_write = hostfs_commit_write
		};

Admin message