Commit ffa0a9a5 authored Oct 06, 2018 by Nathan Chancellor Committed by Pablo Neira Ayuso Oct 09, 2018

netfilter: xt_quota: Don't use aligned attribute in sizeof



Clang warns:

net/netfilter/xt_quota.c:47:44: warning: 'aligned' attribute ignored
when parsing type [-Wignored-attributes]
        BUILD_BUG_ON(sizeof(atomic64_t) != sizeof(__aligned_u64));
                                                  ^~~~~~~~~~~~~

Use 'sizeof(__u64)' instead, as the alignment doesn't affect the size
of the type.

Fixes: e9837e55 ("netfilter: xt_quota: fix the behavior of xt_quota module")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent e9837e55

net/netfilter/xt_quota.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -44,7 +44,7 @@ static int quota_mt_check(const struct xt_mtchk_param *par)
		{
		struct xt_quota_info *q = par->matchinfo;

		BUILD_BUG_ON(sizeof(atomic64_t) != sizeof(__aligned_u64));
		BUILD_BUG_ON(sizeof(atomic64_t) != sizeof(__u64));

		if (q->flags & ~XT_QUOTA_MASK)
		return -EINVAL;

Admin message