Commit ff9458d3 authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

mac80211: remove sent_ps_buffered 



This variable is set once, and tested once.
However, the code path that can set it is
mutually exclusive with the code path that
tests it, so the test is always true. Thus
we also don't need to set it either and can
just remove the variable.

Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 22403def

net/mac80211/ieee80211_i.h

+0 −1
Original line number Diff line number Diff line
@@ -176,7 +176,6 @@ struct ieee80211_rx_data { 
	struct ieee80211_rate *rate;



	unsigned int flags;

	int sent_ps_buffered;

	int queue;

	u32 tkip_iv32;

	u16 tkip_iv16;

net/mac80211/rx.c

+3 −5
Original line number Diff line number Diff line
@@ -789,7 +789,7 @@ static void ap_sta_ps_start(struct sta_info *sta) 
#endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */

}



static int ap_sta_ps_end(struct sta_info *sta)

static void ap_sta_ps_end(struct sta_info *sta)

{

	struct ieee80211_sub_if_data *sdata = sta->sdata;

	struct ieee80211_local *local = sdata->local;
@@ -819,8 +819,6 @@ static int ap_sta_ps_end(struct sta_info *sta) 
	       "since STA not sleeping anymore\n", sdata->dev->name,

	       sta->sta.addr, sta->sta.aid, sent - buffered, buffered);

#endif /* CONFIG_MAC80211_VERBOSE_PS_DEBUG */



	return sent;

}



static ieee80211_rx_result debug_noinline
@@ -879,7 +877,7 @@ ieee80211_rx_h_sta_process(struct ieee80211_rx_data *rx) 
			 */

			if (ieee80211_is_data(hdr->frame_control) &&

			    !ieee80211_has_pm(hdr->frame_control))

				rx->sent_ps_buffered += ap_sta_ps_end(sta);

				ap_sta_ps_end(sta);

		} else {

			if (ieee80211_has_pm(hdr->frame_control))

				ap_sta_ps_start(sta);
@@ -1147,7 +1145,7 @@ ieee80211_rx_h_ps_poll(struct ieee80211_rx_data *rx) 
		if (no_pending_pkts)

			sta_info_clear_tim_bit(rx->sta);

#ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG

	} else if (!rx->sent_ps_buffered) {

	} else {

		/*

		 * FIXME: This can be the result of a race condition between

		 *	  us expiring a frame and the station polling for it.

CRA Git | Maintained and supported by SUSTech CRA and CCSE