Commit ff929696 authored by Manish Chopra's avatar Manish Chopra Committed by David S. Miller
Browse files

qed: Fix LACP pdu drops for VFs 



VF is always configured to drop control frames
(with reserved mac addresses) but to work LACP
on the VFs, it would require LACP control frames
to be forwarded or transmitted successfully.

This patch fixes this in such a way that trusted VFs
(marked through ndo_set_vf_trust) would be allowed to
pass the control frames such as LACP pdus.

Signed-off-by: default avatarManish Chopra <manishc@marvell.com>
Signed-off-by: default avatarAriel Elior <aelior@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9e71a15d

drivers/net/ethernet/qlogic/qed/qed_l2.c

+5 −0
Original line number Diff line number Diff line
@@ -748,6 +748,11 @@ int qed_sp_vport_update(struct qed_hwfn *p_hwfn, 
		return rc;

	}



	if (p_params->update_ctl_frame_check) {

		p_cmn->ctl_frame_mac_check_en = p_params->mac_chk_en;

		p_cmn->ctl_frame_ethtype_check_en = p_params->ethtype_chk_en;

	}



	/* Update mcast bins for VFs, PF doesn't use this functionality */

	qed_sp_update_mcast_bin(p_hwfn, p_ramrod, p_params);

drivers/net/ethernet/qlogic/qed/qed_l2.h

+3 −0
Original line number Diff line number Diff line
@@ -219,6 +219,9 @@ struct qed_sp_vport_update_params { 
	struct qed_rss_params		*rss_params;

	struct qed_filter_accept_flags	accept_flags;

	struct qed_sge_tpa_params	*sge_tpa_params;

	u8				update_ctl_frame_check;

	u8				mac_chk_en;

	u8				ethtype_chk_en;

};



int qed_sp_vport_update(struct qed_hwfn *p_hwfn,

drivers/net/ethernet/qlogic/qed/qed_sriov.c

+8 −2
Original line number Diff line number Diff line
@@ -1969,7 +1969,9 @@ static void qed_iov_vf_mbx_start_vport(struct qed_hwfn *p_hwfn, 
	params.vport_id = vf->vport_id;

	params.max_buffers_per_cqe = start->max_buffers_per_cqe;

	params.mtu = vf->mtu;

	params.check_mac = true;



	/* Non trusted VFs should enable control frame filtering */

	params.check_mac = !vf->p_vf_info.is_trusted_configured;



	rc = qed_sp_eth_vport_start(p_hwfn, &params);

	if (rc) {
@@ -5130,6 +5132,9 @@ static void qed_iov_handle_trust_change(struct qed_hwfn *hwfn) 
		params.opaque_fid = vf->opaque_fid;

		params.vport_id = vf->vport_id;



		params.update_ctl_frame_check = 1;

		params.mac_chk_en = !vf_info->is_trusted_configured;



		if (vf_info->rx_accept_mode & mask) {

			flags->update_rx_mode_config = 1;

			flags->rx_accept_filter = vf_info->rx_accept_mode;
@@ -5147,7 +5152,8 @@ static void qed_iov_handle_trust_change(struct qed_hwfn *hwfn) 
		}



		if (flags->update_rx_mode_config ||

		    flags->update_tx_mode_config)

		    flags->update_tx_mode_config ||

		    params.update_ctl_frame_check)

			qed_sp_vport_update(hwfn, &params,

					    QED_SPQ_MODE_EBLOCK, NULL);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE