Commit ff771bb1 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/ast: Remove obsolete or unused cursor state 



The ast driver's data structures store unused or uncecessary cursor
state. Most of the cursor state is already stored elsewhere and can
be retrieved when necessary. Remove the obsolete fields and adapt
users accordingly.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190613073041.29350-4-tzimmermann@suse.de
parent 4d7553c3

drivers/gpu/drm/ast/ast_drv.h

+0 −7
Original line number Diff line number Diff line
@@ -101,10 +101,6 @@ struct ast_private { 
	int fb_mtrr;



	struct drm_gem_object *cursor_cache;

	uint64_t cursor_cache_gpu_addr;

	/* Acces to this cache is protected by the crtc->mutex of the only crtc

	 * we have. */

	struct ttm_bo_kmap_obj cache_kmap;

	int next_cursor;

	bool support_wide_screen;

	enum {
@@ -236,9 +232,6 @@ struct ast_connector { 


struct ast_crtc {

	struct drm_crtc base;

	struct drm_gem_object *cursor_bo;

	uint64_t cursor_addr;

	int cursor_width, cursor_height;

	u8 offset_x, offset_y;

};

drivers/gpu/drm/ast/ast_mode.c

+17 −14
Original line number Diff line number Diff line
@@ -939,15 +939,13 @@ static int ast_cursor_init(struct drm_device *dev) 
	}



	/* kmap the object */

	base = drm_gem_vram_kmap_at(gbo, true, NULL, &ast->cache_kmap);

	base = drm_gem_vram_kmap(gbo, true, NULL);

	if (IS_ERR(base)) {

		ret = PTR_ERR(base);

		goto fail;

	}



	ast->cursor_cache = obj;

	ast->cursor_cache_gpu_addr = gpu_addr;

	DRM_DEBUG_KMS("pinned cursor cache at %llx\n", ast->cursor_cache_gpu_addr);

	return 0;

fail:

	return ret;
@@ -958,7 +956,7 @@ static void ast_cursor_fini(struct drm_device *dev) 
	struct ast_private *ast = dev->dev_private;

	struct drm_gem_vram_object *gbo =

		drm_gem_vram_of_gem(ast->cursor_cache);

	drm_gem_vram_kunmap_at(gbo, &ast->cache_kmap);

	drm_gem_vram_kunmap(gbo);

	drm_gem_vram_unpin(gbo);

	drm_gem_object_put_unlocked(ast->cursor_cache);

}
@@ -1181,7 +1179,8 @@ static int ast_cursor_set(struct drm_crtc *crtc, 
	struct ast_crtc *ast_crtc = to_ast_crtc(crtc);

	struct drm_gem_object *obj;

	struct drm_gem_vram_object *gbo;

	s64 gpu_addr;

	s64 dst_gpu;

	u64 gpu_addr;

	u32 csum;

	int ret;

	struct ttm_bo_kmap_obj uobj_map;
@@ -1215,14 +1214,19 @@ static int ast_cursor_set(struct drm_crtc *crtc, 
	if (src_isiomem == true)

		DRM_ERROR("src cursor bo should be in main memory\n");



	dst = drm_gem_vram_kmap_at(drm_gem_vram_of_gem(ast->cursor_cache),

				   false, &dst_isiomem, &ast->cache_kmap);

	dst = drm_gem_vram_kmap(drm_gem_vram_of_gem(ast->cursor_cache),

				false, &dst_isiomem);

	if (IS_ERR(dst)) {

		ret = PTR_ERR(dst);

		goto fail_unlock;

	}

	if (dst_isiomem == false)

		DRM_ERROR("dst bo should be in VRAM\n");

	dst_gpu = drm_gem_vram_offset(drm_gem_vram_of_gem(ast->cursor_cache));

	if (dst_gpu < 0) {

		ret = (int)dst_gpu;

		goto fail_unlock;

	}



	dst += (AST_HWC_SIZE + AST_HWC_SIGNATURE_SIZE)*ast->next_cursor;
@@ -1234,8 +1238,9 @@ static int ast_cursor_set(struct drm_crtc *crtc, 


	/* write checksum + signature */

	{

		u8 *dst = drm_gem_vram_kmap_at(drm_gem_vram_of_gem(ast->cursor_cache),

					       false, NULL, &ast->cache_kmap);

		struct drm_gem_vram_object *dst_gbo =

			drm_gem_vram_of_gem(ast->cursor_cache);

		u8 *dst = drm_gem_vram_kmap(dst_gbo, false, NULL);

		dst += (AST_HWC_SIZE + AST_HWC_SIGNATURE_SIZE)*ast->next_cursor + AST_HWC_SIZE;

		writel(csum, dst);

		writel(width, dst + AST_HWC_SIGNATURE_SizeX);
@@ -1244,15 +1249,13 @@ static int ast_cursor_set(struct drm_crtc *crtc, 
		writel(0, dst + AST_HWC_SIGNATURE_HOTSPOTY);



		/* set pattern offset */

		gpu_addr = ast->cursor_cache_gpu_addr;

		gpu_addr = (u64)dst_gpu;

		gpu_addr += (AST_HWC_SIZE + AST_HWC_SIGNATURE_SIZE)*ast->next_cursor;

		gpu_addr >>= 3;

		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xc8, gpu_addr & 0xff);

		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xc9, (gpu_addr >> 8) & 0xff);

		ast_set_index_reg(ast, AST_IO_CRTC_PORT, 0xca, (gpu_addr >> 16) & 0xff);

	}

	ast_crtc->cursor_width = width;

	ast_crtc->cursor_height = height;

	ast_crtc->offset_x = AST_MAX_HWC_WIDTH - width;

	ast_crtc->offset_y = AST_MAX_HWC_WIDTH - height;
@@ -1278,8 +1281,8 @@ static int ast_cursor_move(struct drm_crtc *crtc, 
	int x_offset, y_offset;

	u8 *sig;



	sig = drm_gem_vram_kmap_at(drm_gem_vram_of_gem(ast->cursor_cache),

				   false, NULL, &ast->cache_kmap);

	sig = drm_gem_vram_kmap(drm_gem_vram_of_gem(ast->cursor_cache),

				false, NULL);

	sig += (AST_HWC_SIZE + AST_HWC_SIGNATURE_SIZE)*ast->next_cursor + AST_HWC_SIZE;

	writel(x, sig + AST_HWC_SIGNATURE_X);

	writel(y, sig + AST_HWC_SIGNATURE_Y);

CRA Git | Maintained and supported by SUSTech CRA and CCSE