Commit ff6f7778 authored Nov 07, 2012 by Namhyung Kim Committed by Arnaldo Carvalho de Melo Nov 08, 2012

perf tools: Don't try to lookup objdump for live mode



Arnaldo reported that annotation during perf top resulted in a segfault.
It was because the env->arch was NULL and we don't set it for a live
session.  In fact, no need to look up objdump in this case since we can
use system's default (native) objdump.

Reported-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Irina Tirdea <irina.tirdea@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1352251815-12615-1-git-send-email-namhyung@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent eef9ba98

tools/perf/arch/common.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -199,6 +199,13 @@ out_error:

		int perf_session_env__lookup_objdump(struct perf_session_env *env)
		{
		/*
		* For live mode, env->arch will be NULL and we can use
		* the native objdump tool.
		*/
		if (env->arch == NULL)
		return 0;

		return perf_session_env__lookup_binutils_path(env, "objdump",
		&objdump_path);
		}

Admin message