Commit ff466b58 authored Apr 06, 2019 by Andrey Ignatov Committed by Alexei Starovoitov Apr 06, 2019

libbpf: Ignore -Wformat-nonliteral warning

vsprintf() in __base_pr() uses nonliteral format string and it breaks
compilation for those who provide corresponding extra CFLAGS, e.g.:
https://github.com/libbpf/libbpf/issues/27



If libbpf is built with the flags from PR:

  libbpf.c:68:26: error: format string is not a string literal
  [-Werror,-Wformat-nonliteral]
          return vfprintf(stderr, format, args);
                                  ^~~~~~
  1 error generated.

Ignore this warning since the use case in libbpf.c is legit.

Signed-off-by: Andrey Ignatov <rdna@fb.com>
Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

parent 347807d3

tools/lib/bpf/libbpf.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -52,6 +52,11 @@
		#define BPF_FS_MAGIC 0xcafe4a11
		#endif

		/* vsprintf() in __base_pr() uses nonliteral format string. It may break
		* compilation if user enables corresponding warning. Disable it explicitly.
		*/
		#pragma GCC diagnostic ignored "-Wformat-nonliteral"

		#define __printf(a, b) __attribute__((format(printf, a, b)))

		static int __base_pr(enum libbpf_print_level level, const char *format,

Admin message