Commit ff361fda authored Jun 19, 2018 by Dan Carpenter Committed by Steve French Aug 07, 2018

cifs: Silence uninitialized variable warning



This is not really a runtime issue but Smatch complains that:

    fs/cifs/smb2ops.c:1740 smb2_query_symlink()
    error: uninitialized symbol 'resp_buftype'.

The warning is right that it can be uninitialized...  Also "err_buf"
would be NULL at this point and we're not supposed to pass NULLs to
free_rsp_buf() or it might trigger some extra output if we turn on
debugging.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 1236568e

fs/cifs/smb2ops.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1700,7 +1700,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon,
		&resp_buftype);
		if (!rc \|\| !err_iov.iov_base) {
		rc = -ENOENT;
		goto querty_exit;
		goto free_path;
		}

		err_buf = err_iov.iov_base;
		@@ -1741,6 +1741,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon,

		querty_exit:
		free_rsp_buf(resp_buftype, err_buf);
		free_path:
		kfree(utf16_path);
		return rc;
		}

Admin message