Commit ff351644 authored Dec 03, 2015 by Andrew Lunn Committed by David S. Miller Dec 05, 2015

WAN: HDLC: Detach protocol before unregistering device



The current code first unregisters the device, and then detaches the
protocol from it. This should be performed the other way around, since
the detach may try to use state which has been freed by the
unregister. Swap the order, so that we first detach and then remove the
netdev.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2141eaf0

drivers/net/wan/hdlc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -266,8 +266,8 @@ struct net_device alloc_hdlcdev(void priv)
		void unregister_hdlc_device(struct net_device *dev)
		{
		rtnl_lock();
		unregister_netdevice(dev);
		detach_hdlc_protocol(dev);
		unregister_netdevice(dev);
		rtnl_unlock();
		}

Admin message