Commit ff34f3cc authored Nov 04, 2019 by Will Deacon

firmware: qcom: scm: Ensure 'a0' status code is treated as signed



The 'a0' member of 'struct arm_smccc_res' is declared as 'unsigned long',
however the Qualcomm SCM firmware interface driver expects to receive
negative error codes via this field, so ensure that it's cast to 'long'
before comparing to see if it is less than 0.

Cc: <stable@vger.kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Will Deacon <will@kernel.org>

parent ee9bdfed

drivers/firmware/qcom_scm-64.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -150,7 +150,7 @@ static int qcom_scm_call(struct device *dev, u32 svc_id, u32 cmd_id,
		kfree(args_virt);
		}

		if (res->a0 < 0)
		if ((long)res->a0 < 0)
		return qcom_scm_remap_error(res->a0);

		return 0;

Admin message