Commit ff02c044 authored Aug 21, 2015 by Joonyoung Shim Committed by Alexandre Belloni Sep 05, 2015

rtc: s5m: fix to update ctrl register



According to datasheet, the S2MPS13X and S2MPS14X should update write
buffer via setting WUDR bit to high after ctrl register is written.

If not, ALARM interrupt of rtc-s5m doesn't happen first time when i use
tools/testing/selftests/timers/rtctest.c test program and hour format is
used to 12 hour mode in Odroid-XU3 board.

One more issue is the RTC doesn't keep time on Odroid-XU3 board when i
turn on board after power off even if RTC battery is connected. It can
be solved as setting WUDR & RUDR bits to high at the same time after
RTC_CTRL register is written. It's same with condition of only writing
ALARM registers, so this is for only S2MPS14 and we should set WUDR &
A_UDR bits to high on S2MPS13.

I can't find any reasonable description about this like fix from
datasheet, but can find similar codes from rtc driver source of
hardkernel kernel and vendor kernel.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: <stable@vger.kernel.org> # v3.16
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent 11143c19

drivers/rtc/rtc-s5m.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -635,6 +635,16 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info)
		case S2MPS13X:
		data[0] = (0 << BCD_EN_SHIFT) \| (1 << MODEL24_SHIFT);
		ret = regmap_write(info->regmap, info->regs->ctrl, data[0]);
		if (ret < 0)
		break;

		/*
		* Should set WUDR & (RUDR or AUDR) bits to high after writing
		* RTC_CTRL register like writing Alarm registers. We can't find
		* the description from datasheet but vendor code does that
		* really.
		*/
		ret = s5m8767_rtc_set_alarm_reg(info);
		break;

		default:

Admin message