Commit fedb1bd3 authored Jun 20, 2018 by Marcelo Ricardo Leitner Committed by David S. Miller Jun 21, 2018

sctp: fix erroneous inc of snmp SctpFragUsrMsgs



Currently it is incrementing SctpFragUsrMsgs when the user message size
is of the exactly same size as the maximum fragment size, which is wrong.

The fix is to increment it only when user message is bigger than the
maximum fragment size.

Fixes: bfd2e4b8 ("sctp: refactor sctp_datamsg_from_user")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 92624782

net/sctp/chunk.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -237,7 +237,9 @@ struct sctp_datamsg sctp_datamsg_from_user(struct sctp_association asoc,
		/* Account for a different sized first fragment */
		if (msg_len >= first_len) {
		msg->can_delay = 0;
		SCTP_INC_STATS(sock_net(asoc->base.sk), SCTP_MIB_FRAGUSRMSGS);
		if (msg_len > first_len)
		SCTP_INC_STATS(sock_net(asoc->base.sk),
		SCTP_MIB_FRAGUSRMSGS);
		} else {
		/* Which may be the only one... */
		first_len = msg_len;

Admin message