Commit fed5f571 authored Aug 14, 2017 by Jon Paul Maloy Committed by David S. Miller Aug 14, 2017

tipc: accept PACKET_MULTICAST packets



On L2 bearers, the TIPC broadcast function is sending out packets using
the corresponding L2 broadcast address. At reception, we filter such
packets under the assumption that they will also be delivered as
broadcast packets.

This assumption doesn't always hold true. Under high load, we have seen
that a switch may convert the destination address and deliver the packet
as a PACKET_MULTICAST, something leading to inadvertently dropped
packets and a stale and reset broadcast link.

We fix this by extending the reception filtering to accept packets of
type PACKET_MULTICAST.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2c87d63a

net/tipc/bearer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -596,7 +596,7 @@ static int tipc_l2_rcv_msg(struct sk_buff skb, struct net_device dev,
		rcu_read_lock();
		b = rcu_dereference_rtnl(dev->tipc_ptr);
		if (likely(b && test_bit(0, &b->up) &&
		(skb->pkt_type <= PACKET_BROADCAST))) {
		(skb->pkt_type <= PACKET_MULTICAST))) {
		skb->next = NULL;
		tipc_rcv(dev_net(dev), skb, b);
		rcu_read_unlock();

Admin message