Commit fec99ede authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Doug Ledford
Browse files

RDMA/umem: Avoid partial declaration of non-static function 



The RDMA/umem uses generic RB-trees macros to generate various ib_umem
access functions. The generation is performed with INTERVAL_TREE_DEFINE
macro, which allows one of two modes: declare all functions as static or
declare none of the function to be static.

The second mode of operation produces the following sparse errors:
 drivers/infiniband/core/umem_rbtree.c:69:1:
	warning: symbol 'rbt_ib_umem_iter_first' was not declared.
	Should it be static?
 drivers/infiniband/core/umem_rbtree.c:69:1:
	warning: symbol 'rbt_ib_umem_iter_next' was not declared.
	Should it be static?

Code relocation together with declaration of such functions to be
"static" solves the issue.

Because there is no need to have separate file for two functions,
let's consolidate umem_rtree.c and umem_odp.c into one file.

Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 26beb85f

drivers/infiniband/core/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ ib_core-y := packer.o ud_header.o verbs.o cq.o rw.o sysfs.o \ 
				security.o nldev.o



ib_core-$(CONFIG_INFINIBAND_USER_MEM) += umem.o

ib_core-$(CONFIG_INFINIBAND_ON_DEMAND_PAGING) += umem_odp.o umem_rbtree.o

ib_core-$(CONFIG_INFINIBAND_ON_DEMAND_PAGING) += umem_odp.o

ib_core-$(CONFIG_CGROUP_RDMA) += cgroup.o



ib_cm-y :=			cm.o

drivers/infiniband/core/umem_odp.c

+72 −0
Original line number Diff line number Diff line
@@ -39,11 +39,44 @@ 
#include <linux/export.h>

#include <linux/vmalloc.h>

#include <linux/hugetlb.h>

#include <linux/interval_tree_generic.h>



#include <rdma/ib_verbs.h>

#include <rdma/ib_umem.h>

#include <rdma/ib_umem_odp.h>



/*

 * The ib_umem list keeps track of memory regions for which the HW

 * device request to receive notification when the related memory

 * mapping is changed.

 *

 * ib_umem_lock protects the list.

 */



static u64 node_start(struct umem_odp_node *n)

{

	struct ib_umem_odp *umem_odp =

			container_of(n, struct ib_umem_odp, interval_tree);



	return ib_umem_start(umem_odp->umem);

}



/* Note that the representation of the intervals in the interval tree

 * considers the ending point as contained in the interval, while the

 * function ib_umem_end returns the first address which is not contained

 * in the umem.

 */

static u64 node_last(struct umem_odp_node *n)

{

	struct ib_umem_odp *umem_odp =

			container_of(n, struct ib_umem_odp, interval_tree);



	return ib_umem_end(umem_odp->umem) - 1;

}



INTERVAL_TREE_DEFINE(struct umem_odp_node, rb, u64, __subtree_last,

		     node_start, node_last, static, rbt_ib_umem)



static void ib_umem_notifier_start_account(struct ib_umem *item)

{

	mutex_lock(&item->odp_data->umem_mutex);
@@ -754,3 +787,42 @@ void ib_umem_odp_unmap_dma_pages(struct ib_umem *umem, u64 virt, 
	mutex_unlock(&umem->odp_data->umem_mutex);

}

EXPORT_SYMBOL(ib_umem_odp_unmap_dma_pages);



/* @last is not a part of the interval. See comment for function

 * node_last.

 */

int rbt_ib_umem_for_each_in_range(struct rb_root_cached *root,

				  u64 start, u64 last,

				  umem_call_back cb,

				  void *cookie)

{

	int ret_val = 0;

	struct umem_odp_node *node, *next;

	struct ib_umem_odp *umem;



	if (unlikely(start == last))

		return ret_val;



	for (node = rbt_ib_umem_iter_first(root, start, last - 1);

			node; node = next) {

		next = rbt_ib_umem_iter_next(node, start, last - 1);

		umem = container_of(node, struct ib_umem_odp, interval_tree);

		ret_val = cb(umem->umem, start, last, cookie) || ret_val;

	}



	return ret_val;

}

EXPORT_SYMBOL(rbt_ib_umem_for_each_in_range);



struct ib_umem_odp *rbt_ib_umem_lookup(struct rb_root_cached *root,

				       u64 addr, u64 length)

{

	struct umem_odp_node *node;



	node = rbt_ib_umem_iter_first(root, addr, addr + length - 1);

	if (node)

		return container_of(node, struct ib_umem_odp, interval_tree);

	return NULL;



}

EXPORT_SYMBOL(rbt_ib_umem_lookup);

drivers/infiniband/core/umem_rbtree.c

deleted100644 → 0
+0 −109
Original line number Diff line number Diff line 
/*

 * Copyright (c) 2014 Mellanox Technologies. All rights reserved.

 *

 * This software is available to you under a choice of one of two

 * licenses.  You may choose to be licensed under the terms of the GNU

 * General Public License (GPL) Version 2, available from the file

 * COPYING in the main directory of this source tree, or the

 * OpenIB.org BSD license below:

 *

 *     Redistribution and use in source and binary forms, with or

 *     without modification, are permitted provided that the following

 *     conditions are met:

 *

 *      - Redistributions of source code must retain the above

 *        copyright notice, this list of conditions and the following

 *        disclaimer.

 *

 *      - Redistributions in binary form must reproduce the above

 *        copyright notice, this list of conditions and the following

 *        disclaimer in the documentation and/or other materials

 *        provided with the distribution.

 *

 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,

 * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF

 * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND

 * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS

 * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN

 * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN

 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE

 * SOFTWARE.

 */



#include <linux/kernel.h>

#include <linux/module.h>

#include <linux/interval_tree_generic.h>

#include <linux/sched.h>

#include <linux/gfp.h>

#include <rdma/ib_umem_odp.h>



/*

 * The ib_umem list keeps track of memory regions for which the HW

 * device request to receive notification when the related memory

 * mapping is changed.

 *

 * ib_umem_lock protects the list.

 */



static inline u64 node_start(struct umem_odp_node *n)

{

	struct ib_umem_odp *umem_odp =

			container_of(n, struct ib_umem_odp, interval_tree);



	return ib_umem_start(umem_odp->umem);

}



/* Note that the representation of the intervals in the interval tree

 * considers the ending point as contained in the interval, while the

 * function ib_umem_end returns the first address which is not contained

 * in the umem.

 */

static inline u64 node_last(struct umem_odp_node *n)

{

	struct ib_umem_odp *umem_odp =

			container_of(n, struct ib_umem_odp, interval_tree);



	return ib_umem_end(umem_odp->umem) - 1;

}



INTERVAL_TREE_DEFINE(struct umem_odp_node, rb, u64, __subtree_last,

		     node_start, node_last, , rbt_ib_umem)



/* @last is not a part of the interval. See comment for function

 * node_last.

 */

int rbt_ib_umem_for_each_in_range(struct rb_root_cached *root,

				  u64 start, u64 last,

				  umem_call_back cb,

				  void *cookie)

{

	int ret_val = 0;

	struct umem_odp_node *node, *next;

	struct ib_umem_odp *umem;



	if (unlikely(start == last))

		return ret_val;



	for (node = rbt_ib_umem_iter_first(root, start, last - 1);

			node; node = next) {

		next = rbt_ib_umem_iter_next(node, start, last - 1);

		umem = container_of(node, struct ib_umem_odp, interval_tree);

		ret_val = cb(umem->umem, start, last, cookie) || ret_val;

	}



	return ret_val;

}

EXPORT_SYMBOL(rbt_ib_umem_for_each_in_range);



struct ib_umem_odp *rbt_ib_umem_lookup(struct rb_root_cached *root,

				       u64 addr, u64 length)

{

	struct umem_odp_node *node;



	node = rbt_ib_umem_iter_first(root, addr, addr + length - 1);

	if (node)

		return container_of(node, struct ib_umem_odp, interval_tree);

	return NULL;



}

EXPORT_SYMBOL(rbt_ib_umem_lookup);

include/rdma/ib_umem_odp.h

+0 −4
Original line number Diff line number Diff line
@@ -111,10 +111,6 @@ int ib_umem_odp_map_dma_pages(struct ib_umem *umem, u64 start_offset, u64 bcnt, 
void ib_umem_odp_unmap_dma_pages(struct ib_umem *umem, u64 start_offset,

				 u64 bound);



void rbt_ib_umem_insert(struct umem_odp_node *node,

			struct rb_root_cached *root);

void rbt_ib_umem_remove(struct umem_odp_node *node,

			struct rb_root_cached *root);

typedef int (*umem_call_back)(struct ib_umem *item, u64 start, u64 end,

			      void *cookie);

/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE