Commit fec74874 authored by Maarten Lankhorst's avatar Maarten Lankhorst
Browse files

drm/plane: Clarify our expectations for src/dst rectangles



The rectangles are usually clipped, but it can be useful to have
them unclipped, for example for cursor planes.

Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
[mlankhorst: Change cursor plane to hardware performing clipping. (Ville)
             Fix dst description that went missing.]
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191010112918.15724-1-maarten.lankhorst@linux.intel.com
parent 76d6d3df
Loading
Loading
Loading
Loading
+20 −2
Original line number Diff line number Diff line
@@ -184,8 +184,26 @@ struct drm_plane_state {
	 */
	struct drm_property_blob *fb_damage_clips;

	/** @src: clipped source coordinates of the plane (in 16.16) */
	/** @dst: clipped destination coordinates of the plane */
	/**
	 * @src:
	 *
	 * source coordinates of the plane (in 16.16).
	 *
	 * When using drm_atomic_helper_check_plane_state(),
	 * the coordinates are clipped, but the driver may choose
	 * to use unclipped coordinates instead when the hardware
	 * performs the clipping automatically.
	 */
	/**
	 * @dst:
	 *
	 * clipped destination coordinates of the plane.
	 *
	 * When using drm_atomic_helper_check_plane_state(),
	 * the coordinates are clipped, but the driver may choose
	 * to use unclipped coordinates instead when the hardware
	 * performs the clipping automatically.
	 */
	struct drm_rect src, dst;

	/**