Commit feb28979 authored Feb 11, 2015 by Lorenzo Pieralisi Committed by Bjorn Helgaas Feb 11, 2015

of/pci: Remove duplicate kfree in of_pci_get_host_bridge_resources()



Commit d2be00c0 ("of/pci: Free resources on failure in
of_pci_get_host_bridge_resources()") fixed the error path so it frees
everything on the "resources" list.  That list includes the bus_range, so
we should not free it again.

Remove the superfluous free of bus_range.

[bhelgaas: changelog]
Fixes: d2be00c0 ("of/pci: Free resources on failure in of_pci_get_host_bridge_resources()")
Reported-by: Jiang Liu <jiang.liu@linux.intel.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Rafael J. Wysocki <rjw@rjwysocki.net>

parent 87291235

drivers/of/of_pci.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -229,7 +229,6 @@ parse_failed:
		resource_list_for_each_entry(window, resources)
		kfree(window->res);
		pci_free_resource_list(resources);
		kfree(bus_range);
		return err;
		}
		EXPORT_SYMBOL_GPL(of_pci_get_host_bridge_resources);

Admin message