Commit fe9f3877 authored Jun 12, 2008 by Joel Becker Committed by Mark Fasheh Jul 14, 2008

ocfs2: Don't snprintf() without a format.



Some system files are per-slot.  Their names include the slot number.
ocfs2_sprintf_system_inode_name() uses the system inode definitions to
fill in the slot number with snprintf().

For global system files, there is no node number, and the name was
printed as a format with no arguments.  -Wformat-nonliteral and
-Wformat-security don't like this.  Instead, use a static "%s" format
and the name as the argument.

Signed-off-by: Joel Becker <joel.becker@oracle.com>

parent e407e397

fs/ocfs2/ocfs2_fs.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -901,7 +901,7 @@ static inline int ocfs2_sprintf_system_inode_name(char *buf, int len,
		* list has a copy per slot.
		*/
		if (type <= OCFS2_LAST_GLOBAL_SYSTEM_INODE)
		chars = snprintf(buf, len,
		chars = snprintf(buf, len, "%s",
		ocfs2_system_inodes[type].si_name);
		else
		chars = snprintf(buf, len,

Admin message