Commit fe8abf33 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Felipe Balbi
Browse files

usb: dwc3: support clocks and resets for DWC3 core 

Historically, the clocks and resets are handled on the glue layer
side instead of the DWC3 core.  For simple cases, dwc3-of-simple.c
takes care of arbitrary number of clocks and resets.  The DT node
structure typically looks like as follows:

  dwc3-glue {
          compatible = "foo,dwc3";
          clocks = ...;
          resets = ...;
          ...

          dwc3 {
                  compatible = "snps,dwc3";
                  ...
          };
  }

By supporting the clocks and the reset in the dwc3/core.c, it will
be turned into a single node:

  dwc3 {
          compatible = "foo,dwc3", "snps,dwc3";
          clocks = ...;
          resets = ...;
          ...
  }

This commit adds the binding of clocks and resets specific to this IP.
The number of clocks should generally be the same across SoCs, it is
just some SoCs either tie clocks together or do not provide software
control of some of the clocks.

I took the clock names from the Synopsys datasheet: "ref" (ref_clk),
"bus_early" (bus_clk_early), and "suspend" (suspend_clk).

I found only one reset line in the datasheet, hence the reset-names
property is omitted.

Those clocks are required for new platforms.  Enforcing the new
binding breaks existing platforms since they specify clocks (and
resets) in their glue layer node, but nothing in the core node.
I listed such exceptional cases in the DT binding.  The driver
code has been relaxed to accept no clock.  This change is based
on the discussion [1].

I inserted reset_control_deassert() and clk_bulk_enable() before the
first register access, i.e. dwc3_cache_hwparams().

[1] https://patchwork.kernel.org/patch/10284265/



Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 4d4ca013

Documentation/devicetree/bindings/usb/dwc3.txt

+21 −0
Original line number Diff line number Diff line
@@ -7,6 +7,26 @@ Required properties: 
 - compatible: must be "snps,dwc3"

 - reg : Address and length of the register set for the device

 - interrupts: Interrupts used by the dwc3 controller.

 - clock-names: should contain "ref", "bus_early", "suspend"

 - clocks: list of phandle and clock specifier pairs corresponding to

           entries in the clock-names property.



Exception for clocks:

  clocks are optional if the parent node (i.e. glue-layer) is compatible to

  one of the following:

    "amlogic,meson-axg-dwc3"

    "amlogic,meson-gxl-dwc3"

    "cavium,octeon-7130-usb-uctl"

    "qcom,dwc3"

    "samsung,exynos5250-dwusb3"

    "samsung,exynos7-dwusb3"

    "sprd,sc9860-dwc3"

    "st,stih407-dwc3"

    "ti,am437x-dwc3"

    "ti,dwc3"

    "ti,keystone-dwc3"

    "rockchip,rk3399-dwc3"

    "xlnx,zynqmp-dwc3"



Optional properties:

 - usb-phy : array of phandle for the PHY device.  The first element
@@ -15,6 +35,7 @@ Optional properties: 
 - phys: from the *Generic PHY* bindings

 - phy-names: from the *Generic PHY* bindings; supported names are "usb2-phy"

	or "usb3-phy".

 - resets: a single pair of phandle and reset specifier

 - snps,usb3_lpm_capable: determines if platform is USB3 LPM capable

 - snps,disable_scramble_quirk: true when SW should disable data scrambling.

	Only really useful for FPGA builds.

drivers/usb/dwc3/core.c

+86 −2
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
 *	    Sebastian Andrzej Siewior <bigeasy@linutronix.de>

 */



#include <linux/clk.h>

#include <linux/version.h>

#include <linux/module.h>

#include <linux/kernel.h>
@@ -24,6 +25,7 @@ 
#include <linux/of.h>

#include <linux/acpi.h>

#include <linux/pinctrl/consumer.h>

#include <linux/reset.h>



#include <linux/usb/ch9.h>

#include <linux/usb/gadget.h>
@@ -266,6 +268,12 @@ done: 
	return 0;

}



static const struct clk_bulk_data dwc3_core_clks[] = {

	{ .id = "ref" },

	{ .id = "bus_early" },

	{ .id = "suspend" },

};



/*

 * dwc3_frame_length_adjustment - Adjusts frame length if required

 * @dwc3: Pointer to our controller context structure
@@ -667,6 +675,9 @@ static void dwc3_core_exit(struct dwc3 *dwc) 
	usb_phy_set_suspend(dwc->usb3_phy, 1);

	phy_power_off(dwc->usb2_generic_phy);

	phy_power_off(dwc->usb3_generic_phy);

	clk_bulk_disable(dwc->num_clks, dwc->clks);

	clk_bulk_unprepare(dwc->num_clks, dwc->clks);

	reset_control_assert(dwc->reset);

}



static bool dwc3_core_is_valid(struct dwc3 *dwc)
@@ -1256,6 +1267,12 @@ static int dwc3_probe(struct platform_device *pdev) 
	if (!dwc)

		return -ENOMEM;



	dwc->clks = devm_kmemdup(dev, dwc3_core_clks, sizeof(dwc3_core_clks),

				 GFP_KERNEL);

	if (!dwc->clks)

		return -ENOMEM;



	dwc->num_clks = ARRAY_SIZE(dwc3_core_clks);

	dwc->dev = dev;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -1286,6 +1303,32 @@ static int dwc3_probe(struct platform_device *pdev) 


	dwc3_get_properties(dwc);



	dwc->reset = devm_reset_control_get_optional_shared(dev, NULL);

	if (IS_ERR(dwc->reset))

		return PTR_ERR(dwc->reset);



	ret = clk_bulk_get(dev, dwc->num_clks, dwc->clks);

	if (ret == -EPROBE_DEFER)

		return ret;

	/*

	 * Clocks are optional, but new DT platforms should support all clocks

	 * as required by the DT-binding.

	 */

	if (ret)

		dwc->num_clks = 0;



	ret = reset_control_deassert(dwc->reset);

	if (ret)

		goto put_clks;



	ret = clk_bulk_prepare(dwc->num_clks, dwc->clks);

	if (ret)

		goto assert_reset;



	ret = clk_bulk_enable(dwc->num_clks, dwc->clks);

	if (ret)

		goto unprepare_clks;



	platform_set_drvdata(pdev, dwc);

	dwc3_cache_hwparams(dwc);
@@ -1349,6 +1392,14 @@ err1: 
	pm_runtime_put_sync(&pdev->dev);

	pm_runtime_disable(&pdev->dev);



	clk_bulk_disable(dwc->num_clks, dwc->clks);

unprepare_clks:

	clk_bulk_unprepare(dwc->num_clks, dwc->clks);

assert_reset:

	reset_control_assert(dwc->reset);

put_clks:

	clk_bulk_put(dwc->num_clks, dwc->clks);



	return ret;

}
@@ -1370,11 +1421,44 @@ static int dwc3_remove(struct platform_device *pdev) 


	dwc3_free_event_buffers(dwc);

	dwc3_free_scratch_buffers(dwc);

	clk_bulk_put(dwc->num_clks, dwc->clks);



	return 0;

}



#ifdef CONFIG_PM

static int dwc3_core_init_for_resume(struct dwc3 *dwc)

{

	int ret;



	ret = reset_control_deassert(dwc->reset);

	if (ret)

		return ret;



	ret = clk_bulk_prepare(dwc->num_clks, dwc->clks);

	if (ret)

		goto assert_reset;



	ret = clk_bulk_enable(dwc->num_clks, dwc->clks);

	if (ret)

		goto unprepare_clks;



	ret = dwc3_core_init(dwc);

	if (ret)

		goto disable_clks;



	return 0;



disable_clks:

	clk_bulk_disable(dwc->num_clks, dwc->clks);

unprepare_clks:

	clk_bulk_unprepare(dwc->num_clks, dwc->clks);

assert_reset:

	reset_control_assert(dwc->reset);



	return ret;

}



static int dwc3_suspend_common(struct dwc3 *dwc, pm_message_t msg)

{

	unsigned long	flags;
@@ -1438,7 +1522,7 @@ static int dwc3_resume_common(struct dwc3 *dwc, pm_message_t msg) 


	switch (dwc->current_dr_role) {

	case DWC3_GCTL_PRTCAP_DEVICE:

		ret = dwc3_core_init(dwc);

		ret = dwc3_core_init_for_resume(dwc);

		if (ret)

			return ret;
@@ -1449,7 +1533,7 @@ static int dwc3_resume_common(struct dwc3 *dwc, pm_message_t msg) 
		break;

	case DWC3_GCTL_PRTCAP_HOST:

		if (!PMSG_IS_AUTO(msg)) {

			ret = dwc3_core_init(dwc);

			ret = dwc3_core_init_for_resume(dwc);

			if (ret)

				return ret;

			dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_HOST);

drivers/usb/dwc3/core.h

+8 −0
Original line number Diff line number Diff line
@@ -891,6 +891,9 @@ struct dwc3_scratchpad_array { 
 * @eps: endpoint array

 * @gadget: device side representation of the peripheral controller

 * @gadget_driver: pointer to the gadget driver

 * @clks: array of clocks

 * @num_clks: number of clocks

 * @reset: reset control

 * @regs: base address for our registers

 * @regs_size: address space size

 * @fladj: frame length adjustment
@@ -1013,6 +1016,11 @@ struct dwc3 { 
	struct usb_gadget	gadget;

	struct usb_gadget_driver *gadget_driver;



	struct clk_bulk_data	*clks;

	int			num_clks;



	struct reset_control	*reset;



	struct usb_phy		*usb2_phy;

	struct usb_phy		*usb3_phy;

CRA Git | Maintained and supported by SUSTech CRA and CCSE