Commit fe6f0cdc authored Oct 07, 2020 by Johannes Thumshirn Committed by Jens Axboe Oct 07, 2020

block: soft limit zone-append sectors as well



Martin rightfully noted that for normal filesystem IO we have soft limits
in place, to prevent them from getting too big and not lead to
unpredictable latencies. For zone append we only have the hardware limit
in place.

Cap the max sectors we submit via zone-append to the maximal number of
sectors if the second limit is lower.

Reported-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/linux-btrfs/yq1k0w8g3rw.fsf@ca-mkp.ca.oracle.com


Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent a926c7af

include/linux/blkdev.h

+4 −1

Original line number	Diff line number	Diff line
		@@ -1407,7 +1407,10 @@ static inline unsigned int queue_max_segment_size(const struct request_queue *q)

		static inline unsigned int queue_max_zone_append_sectors(const struct request_queue *q)
		{
		return q->limits.max_zone_append_sectors;

		const struct queue_limits *l = &q->limits;

		return min(l->max_zone_append_sectors, l->max_sectors);
		}

		static inline unsigned queue_logical_block_size(const struct request_queue *q)

Admin message