Unverified Commit fe6c473e authored by Linus Walleij's avatar Linus Walleij Committed by Mark Brown
Browse files

gpio: Export gpiod_get_from_of_node() 



This function already exist inside gpiolib, we were just
reluctant to make it available to the kernel at large as
the devm_* seemed to be enough for anyone.

However we found out that regulators need to do their own
lifecycle/refcounting on GPIO descriptors and explicitly
call gpiod_put() when done with a descriptor, so export
this function so we can hand the refcounting over to the
regulator core for these descriptors after retrieveal.

Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 894077d5

drivers/gpio/gpiolib.h

+0 −6
Original line number Diff line number Diff line
@@ -201,12 +201,6 @@ int gpiod_set_array_value_complex(bool raw, bool can_sleep, 
				  struct gpio_array *array_info,

				  unsigned long *value_bitmap);



/* This is just passed between gpiolib and devres */

struct gpio_desc *gpiod_get_from_of_node(struct device_node *node,

					 const char *propname, int index,

					 enum gpiod_flags dflags,

					 const char *label);



extern struct spinlock gpio_lock;

extern struct list_head gpio_devices;

include/linux/gpio/consumer.h

+13 −0
Original line number Diff line number Diff line
@@ -172,6 +172,10 @@ int desc_to_gpio(const struct gpio_desc *desc); 
struct device_node;

struct fwnode_handle;



struct gpio_desc *gpiod_get_from_of_node(struct device_node *node,

					 const char *propname, int index,

					 enum gpiod_flags dflags,

					 const char *label);

struct gpio_desc *devm_gpiod_get_from_of_node(struct device *dev,

					      struct device_node *node,

					      const char *propname, int index,
@@ -517,6 +521,15 @@ static inline int desc_to_gpio(const struct gpio_desc *desc) 
struct device_node;

struct fwnode_handle;



static inline

struct gpio_desc *gpiod_get_from_of_node(struct device_node *node,

					 const char *propname, int index,

					 enum gpiod_flags dflags,

					 const char *label)

{

	return ERR_PTR(-ENOSYS);

}



static inline

struct gpio_desc *devm_gpiod_get_from_of_node(struct device *dev,

					      struct device_node *node,

CRA Git | Maintained and supported by SUSTech CRA and CCSE