Commit fe6a8fc5 authored Aug 10, 2020 by Lennart Poettering Committed by Jens Axboe Aug 11, 2020

loop: unset GENHD_FL_NO_PART_SCAN on LOOP_CONFIGURE



When LOOP_CONFIGURE is used with LO_FLAGS_PARTSCAN we need to propagate
this into the GENHD_FL_NO_PART_SCAN. LOOP_SETSTATUS does this,
LOOP_CONFIGURE doesn't so far. Effect is that setting up a loopback
device with partition scanning doesn't actually work when LOOP_CONFIGURE
is issued, though it works fine with LOOP_SETSTATUS.

Let's correct that and propagate the flag in LOOP_CONFIGURE too.

Fixes: 3448914e("loop: Add LOOP_CONFIGURE ioctl")

Signed-off-by: Lennart Poettering <lennart@poettering.net>
Acked-by: Martijn Coenen <maco@android.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 905e321e

drivers/block/loop.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1171,6 +1171,8 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,
		if (part_shift)
		lo->lo_flags \|= LO_FLAGS_PARTSCAN;
		partscan = lo->lo_flags & LO_FLAGS_PARTSCAN;
		if (partscan)
		lo->lo_disk->flags &= ~GENHD_FL_NO_PART_SCAN;

		/* Grab the block_device to prevent its destruction after we
		* put /dev/loopXX inode. Later in __loop_clr_fd() we bdput(bdev).

Admin message