Commit fe658f94 authored Jul 10, 2017 by Steffen Maier Committed by Linus Torvalds Jul 10, 2017

checkpatch: [HLP]LIST_HEAD is also declaration

Fixes the following false warning among others for LLIST_HEAD and
PLIST_HEAD:

    WARNING: Missing a blank line after declarations
    #71: FILE: drivers/s390/scsi/zfcp_fsf.c:422:
    +	struct hlist_node *tmp;
    +	HLIST_HEAD(remove_queue);

Link: http://lkml.kernel.org/r/20170614133512.89425-1-maier@linux.vnet.ibm.com


Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 628f91a2

scripts/checkpatch.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -733,7 +733,7 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc\|$Constant\|$String)};

		our $declaration_macros = qr{(?x:
		(?:$Storage\s+)?(?:[A-Z_][A-Z0-9]_){0,2}(?:DEFINE\|DECLARE)(?:_[A-Z0-9]+){1,6}\s\(\|
		(?:$Storage\s+)?LIST_HEAD\s*\(\|
		(?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(\|
		(?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
		)};

Admin message