Commit fe63604c authored Jul 08, 2019 by Markus Elfring Committed by Alexandre Belloni Jul 13, 2019

rtc: stm32: remove one condition check in stm32_rtc_set_alarm()



A condition check was repeated in this function implementation despite of
a corresponding check in the stm32_rtc_alarm_irq_enable() function.
Thus delete redundant source code here.

This issue was detected by using the Coccinelle software.

Suggested-by: Russell King <linux@armlinux.org.uk>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com>
Link: https://lore.kernel.org/r/4da614a4-83c6-548c-a112-033b846c561b@web.de


Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

parent f2f5cb6a

drivers/rtc/rtc-stm32.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -519,11 +519,7 @@ static int stm32_rtc_set_alarm(struct device dev, struct rtc_wkalrm alrm)
		/* Write to Alarm register */
		writel_relaxed(alrmar, rtc->base + regs->alrmar);

		if (alrm->enabled)
		stm32_rtc_alarm_irq_enable(dev, 1);
		else
		stm32_rtc_alarm_irq_enable(dev, 0);

		stm32_rtc_alarm_irq_enable(dev, alrm->enabled);
		end:
		stm32_rtc_wpr_lock(rtc);

Admin message