lustre/mdc: comments on LOOKUP and PERM lock (fe4c58af) · Commits · 戴 / test

drivers/staging/lustre/lustre/include/lustre/lustre_idl.h

+18 −6

Original line number	Diff line number	Diff line
		@@ -2116,11 +2116,23 @@ extern void lustre_swab_generic_32s (__u32 *val);
		#define DISP_OPEN_LEASE 0x04000000

		/* INODE LOCK PARTS */
		#define MDS_INODELOCK_LOOKUP 0x000001 /* dentry, mode, owner, group */
		#define MDS_INODELOCK_LOOKUP 0x000001 /* For namespace, dentry etc, and also
		* was used to protect permission (mode,
		* owner, group etc) before 2.4. */
		#define MDS_INODELOCK_UPDATE 0x000002 /* size, links, timestamps */
		#define MDS_INODELOCK_OPEN 0x000004 /* For opened files */
		#define MDS_INODELOCK_LAYOUT 0x000008 /* for layout */
		#define MDS_INODELOCK_PERM 0x000010 /* for permission */

		/* The PERM bit is added int 2.4, and it is used to protect permission(mode,
		* owner, group, acl etc), so to separate the permission from LOOKUP lock.
		* Because for remote directories(in DNE), these locks will be granted by
		* different MDTs(different ldlm namespace).
		*
		* For local directory, MDT will always grant UPDATE_LOCK\|PERM_LOCK together.
		* For Remote directory, the master MDT, where the remote directory is, will
		* grant UPDATE_LOCK\|PERM_LOCK, and the remote MDT, where the name entry is,
		* will grant LOOKUP_LOCK. */
		#define MDS_INODELOCK_PERM 0x000010
		#define MDS_INODELOCK_XATTR 0x000020 /* extended attributes */

		#define MDS_INODELOCK_MAXSHIFT 5

+3 −0

Original line number	Diff line number	Diff line
		@@ -1072,6 +1072,9 @@ int mdc_revalidate_lock(struct obd_export exp, struct lookup_intent it,
		* locks, there's no easy way to match all of them here,
		* so an extra RPC would be performed to fetch all
		* of those bits at once for now. */
		/* For new MDTs(> 2.4), UPDATE\|PERM should be enough,
		* but for old MDTs (< 2.4), permission is covered
		* by LOOKUP lock, so it needs to match all bits here.*/
		policy.l_inodebits.bits = MDS_INODELOCK_UPDATE \|
		MDS_INODELOCK_LOOKUP \|
		MDS_INODELOCK_PERM;