batman-adv: Only increase refcounter once for alternate router (fe3f4cfe) · Commits · 戴 / test

The test whether we can use a router for alternating bonding should only be done once because it is already known that it is still usable and will not be deleted from the list soon. This patch addresses Coverity #712285: Unchecked return value Signed-off-by:

Sven Eckelmann <sven@narfation.org> Signed-off-by:

Antonio Quartulli <ordex@autistici.org>

net/batman-adv/routing.c

+8 −15

Original line number	Diff line number	Diff line
		@@ -549,25 +549,18 @@ batadv_find_ifalter_router(struct batadv_orig_node *primary_orig,
		if (tmp_neigh_node->if_incoming == recv_if)
		continue;

		if (router && tmp_neigh_node->tq_avg <= router->tq_avg)
		continue;

		if (!atomic_inc_not_zero(&tmp_neigh_node->refcount))
		continue;

		/* if we don't have a router yet
		* or this one is better, choose it.
		*/
		if ((!router) \|\|
		(tmp_neigh_node->tq_avg > router->tq_avg)) {
		/* decrement refcount of
		* previously selected router
		*/
		/* decrement refcount of previously selected router */
		if (router)
		batadv_neigh_node_free_ref(router);

		/* we found a better router (or at least one valid router) */
		router = tmp_neigh_node;
		atomic_inc_not_zero(&router->refcount);
		}

		batadv_neigh_node_free_ref(tmp_neigh_node);
		}

		/* use the first candidate if nothing was found. */

Admin message