Commit fe2e082f authored Aug 20, 2019 by Wenwen Wang Committed by Tyler Hicks Aug 20, 2019

ecryptfs: fix a memory leak bug in parse_tag_1_packet()



In parse_tag_1_packet(), if tag 1 packet contains a key larger than
ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES, no cleanup is executed, leading to a
memory leak on the allocated 'auth_tok_list_item'. To fix this issue, go to
the label 'out_free' to perform the cleanup work.

Cc: stable@vger.kernel.org
Fixes: dddfa461 ("[PATCH] eCryptfs: Public key; packet management")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>

parent 5f97cbe2

fs/ecryptfs/keystore.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1304,7 +1304,7 @@ parse_tag_1_packet(struct ecryptfs_crypt_stat *crypt_stat,
		printk(KERN_WARNING "Tag 1 packet contains key larger "
		"than ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES\n");
		rc = -EINVAL;
		goto out;
		goto out_free;
		}
		memcpy((*new_auth_tok)->session_key.encrypted_key,
		&data[(*packet_size)], (body_size - (ECRYPTFS_SIG_SIZE + 2)));

Admin message