Commit fe2c4d01 authored Jul 08, 2009 by Tejun Heo Committed by Jeff Garzik Jul 14, 2009

libata: fix follow-up SRST failure path



ata_eh_reset() was missing error return handling after follow-up SRST
allowing EH to continue the normal probing path after reset failure.
This was discovered while testing new WD 2TB drives which take longer
than 10 secs to spin up and cause the first follow-up SRST to time
out.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 6847e154

drivers/ata/libata-eh.c

+4 −0

Original line number	Original line	Diff line number	Diff line
	@@ -2517,6 +2517,10 @@ int ata_eh_reset(struct ata_link *link, int classify,

	ata_eh_about_to_do(link, NULL, ATA_EH_RESET);		ata_eh_about_to_do(link, NULL, ATA_EH_RESET);
	rc = ata_do_reset(link, reset, classes, deadline, true);		rc = ata_do_reset(link, reset, classes, deadline, true);
			if (rc) {
			failed_link = link;
			goto fail;
			}
	}		}
	} else {		} else {
	if (verbose)		if (verbose)

Admin message