Commit fe0fe835 authored by Boaz Harrosh's avatar Boaz Harrosh Committed by Trond Myklebust
Browse files

pnfs-obj: Must return layout on IO error 



As mandated by the standard. In case of an IO error, a pNFS
objects layout driver must return it's layout. This is because
all device errors are reported to the server as part of the
layout return buffer.

This is implemented the same way PNFS_LAYOUTRET_ON_SETATTR
is done, through a bit flag on the pnfs_layoutdriver_type->flags
member. The flag is set by the layout driver that wants a
layout_return preformed at pnfs_ld_{write,read}_done in case
of an error.
(Though I have not defined a wrapper like pnfs_ld_layoutret_on_setattr
 because this code is never called outside of pnfs.c and pnfs IO
 paths)

Without this patch 3.[0-2] Kernels leak memory and have an annoying
WARN_ON after every IO error utilizing the pnfs-obj driver.

[This patch is for 3.2 Kernel. 3.1/0 Kernels need a different patch]
CC: Stable Tree <stable@kernel.org>
Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 5c0b4129

fs/nfs/objlayout/objio_osd.c

+2 −1
Original line number Diff line number Diff line
@@ -551,7 +551,8 @@ static const struct nfs_pageio_ops objio_pg_write_ops = { 
static struct pnfs_layoutdriver_type objlayout_type = {

	.id = LAYOUT_OSD2_OBJECTS,

	.name = "LAYOUT_OSD2_OBJECTS",

	.flags                   = PNFS_LAYOUTRET_ON_SETATTR,

	.flags                   = PNFS_LAYOUTRET_ON_SETATTR |

				   PNFS_LAYOUTRET_ON_ERROR,



	.alloc_layout_hdr        = objlayout_alloc_layout_hdr,

	.free_layout_hdr         = objlayout_free_layout_hdr,

fs/nfs/pnfs.c

+12 −0
Original line number Diff line number Diff line
@@ -1178,6 +1178,15 @@ void pnfs_ld_write_done(struct nfs_write_data *data) 
		put_lseg(data->lseg);

		data->lseg = NULL;

		dprintk("pnfs write error = %d\n", data->pnfs_error);

		if (NFS_SERVER(data->inode)->pnfs_curr_ld->flags &

						PNFS_LAYOUTRET_ON_ERROR) {

			/* Don't lo_commit on error, Server will needs to

			 * preform a file recovery.

			 */

			clear_bit(NFS_INO_LAYOUTCOMMIT,

				  &NFS_I(data->inode)->flags);

			pnfs_return_layout(data->inode);

		}

	}

	data->mds_ops->rpc_release(data);

}
@@ -1267,6 +1276,9 @@ static void pnfs_ld_handle_read_error(struct nfs_read_data *data) 
	put_lseg(data->lseg);

	data->lseg = NULL;

	dprintk("pnfs write error = %d\n", data->pnfs_error);

	if (NFS_SERVER(data->inode)->pnfs_curr_ld->flags &

						PNFS_LAYOUTRET_ON_ERROR)

		pnfs_return_layout(data->inode);



	nfs_pageio_init_read_mds(&pgio, data->inode);

fs/nfs/pnfs.h

+1 −0
Original line number Diff line number Diff line
@@ -68,6 +68,7 @@ enum { 
enum layoutdriver_policy_flags {

	/* Should the pNFS client commit and return the layout upon a setattr */

	PNFS_LAYOUTRET_ON_SETATTR	= 1 << 0,

	PNFS_LAYOUTRET_ON_ERROR		= 1 << 1,

};



struct nfs4_deviceid_node;

CRA Git | Maintained and supported by SUSTech CRA and CCSE