Commit fe0dfd63 authored May 04, 2017 by Yifeng Li Committed by Mark Brown May 14, 2017

rt286: add Thinkpad Helix 2 to force_combo_jack_table

Thinkpad Helix 2 is a tablet PC, the audio is powered by Core M
broadwell-audio and rt286 codec. For all versions of Linux kernel,
the stereo output doesn't work properly when earphones are plugged
in, the sound was coming out from both channels even if the audio
contains only the left or right channel. Furthermore, if a music
recorded in stereo is played, the two channels cancle out each other
out, as a result, no voice but only distorted background music can be
heard, like a sound card with builtin a Karaoke sount effect.

Apparently this tablet uses a combo jack with polarity incorrectly
set by rt286 driver. This patch adds DMI information of Thinkpad Helix 2
to force_combo_jack_table[] and the issue is resolved. The microphone
input doesn't work regardless to the presence of this patch and still
needs help from other developers to investigate.

This is my first patch to LKML directly, sorry for CC-ing too many
people here.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=93841


Signed-off-by: Yifeng Li <tomli@tomli.me>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 2ea659a9

sound/soc/codecs/rt286.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1108,6 +1108,13 @@ static const struct dmi_system_id force_combo_jack_table[] = {
		DMI_MATCH(DMI_PRODUCT_NAME, "Kabylake Client platform")
		}
		},
		{
		.ident = "Thinkpad Helix 2nd",
		.matches = {
		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
		DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad Helix 2nd")
		}
		},

		{ }
		};

Admin message