Commit fdf96a90 authored by Steve French's avatar Steve French Committed by Steve French
Browse files

Handle big endianness in NTLM (ntlmv2) authentication 



This is RH bug 970891
Uppercasing of username during calculation of ntlmv2 hash fails
because UniStrupr function does not handle big endian wchars.

Also fix a comment in the same code to reflect its correct usage.

[To make it easier for stable (rather than require 2nd patch) fixed
this patch of Shirish's to remove endian warning generated
by sparse -- steve f.]

Reported-by: default avatarsteve <sanpatr1@in.ibm.com>
Signed-off-by: default avatarShirish Pargaonkar <shirishpargaonkar@gmail.com>
Cc: <stable@kernel.org>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
parent 2a2c41c0

fs/cifs/cifs_unicode.h

+4 −4
Original line number Diff line number Diff line
@@ -327,14 +327,14 @@ UniToupper(register wchar_t uc) 
/*

 * UniStrupr:  Upper case a unicode string

 */

static inline wchar_t *

UniStrupr(register wchar_t *upin)

static inline __le16 *

UniStrupr(register __le16 *upin)

{

	register wchar_t *up;

	register __le16 *up;



	up = upin;

	while (*up) {		/* For all characters */

		*up = UniToupper(*up);

		*up = cpu_to_le16(UniToupper(le16_to_cpu(*up)));

		up++;

	}

	return upin;		/* Return input pointer */

fs/cifs/cifsencrypt.c

+3 −3
Original line number Diff line number Diff line
@@ -413,7 +413,7 @@ static int calc_ntlmv2_hash(struct cifs_ses *ses, char *ntlmv2_hash, 
	int rc = 0;

	int len;

	char nt_hash[CIFS_NTHASH_SIZE];

	wchar_t *user;

	__le16 *user;

	wchar_t *domain;

	wchar_t *server;
@@ -438,7 +438,7 @@ static int calc_ntlmv2_hash(struct cifs_ses *ses, char *ntlmv2_hash, 
		return rc;

	}



	/* convert ses->user_name to unicode and uppercase */

	/* convert ses->user_name to unicode */

	len = ses->user_name ? strlen(ses->user_name) : 0;

	user = kmalloc(2 + (len * 2), GFP_KERNEL);

	if (user == NULL) {
@@ -447,7 +447,7 @@ static int calc_ntlmv2_hash(struct cifs_ses *ses, char *ntlmv2_hash, 
	}



	if (len) {

		len = cifs_strtoUTF16((__le16 *)user, ses->user_name, len, nls_cp);

		len = cifs_strtoUTF16(user, ses->user_name, len, nls_cp);

		UniStrupr(user);

	} else {

		memset(user, '\0', 2);

CRA Git | Maintained and supported by SUSTech CRA and CCSE