Commit fdf8cb09 authored Sep 29, 2006 by Andreas Mohr Committed by Linus Torvalds Sep 29, 2006

[PATCH] lib/rwsem.c: un-inline rwsem_down_failed_common()



Un-inlining rwsem_down_failed_common() (two callsites) reduced lib/rwsem.o
on my Athlon, gcc 4.1.2 from 5935 to 5480 Bytes (455 Bytes saved).

I thus guess that reduced icache footprint (and better function caching) is
worth more than any function call overhead.

Signed-off-by: Andreas Mohr <andi@lisas.de>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 2752e401

lib/rwsem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -146,7 +146,7 @@ __rwsem_do_wake(struct rw_semaphore *sem, int downgrading)
		/*
		* wait for a lock to be granted
		*/
		static inline struct rw_semaphore *
		static struct rw_semaphore *
		rwsem_down_failed_common(struct rw_semaphore *sem,
		struct rwsem_waiter *waiter, signed long adjustment)
		{

Admin message