Commit fdadf267 authored Feb 24, 2015 by Eric Sandeen Committed by Dave Chinner Feb 24, 2015

xfs: clarify async write failure ratelimit message



Today, when the "failing async writes" get ratelimited, we see:

XFS:: 62836 callbacks suppressed

Aside from the extra ":" it's not entirely clear which message is being
suppressed, especially if other messages or ratelimits are happening
at the same time.  Clarify this as i.e.:

XFS (dm-11): Failing async write on buffer block 0x140090. Retrying async write.
XFS: Failing async write: 62836 callbacks suppressed

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>

parent 3b9ce795

fs/xfs/xfs_buf_item.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -537,9 +537,9 @@ xfs_buf_item_push(

		/* has a previous flush failed due to IO errors? */
		if ((bp->b_flags & XBF_WRITE_FAIL) &&
		___ratelimit(&xfs_buf_write_fail_rl_state, "XFS:")) {
		___ratelimit(&xfs_buf_write_fail_rl_state, "XFS: Failing async write")) {
		xfs_warn(bp->b_target->bt_mount,
		"Detected failing async write on buffer block 0x%llx. Retrying async write.",
		"Failing async write on buffer block 0x%llx. Retrying async write.",
		(long long)bp->b_bn);
		}

Admin message