Commit fda0fd6c authored Oct 14, 2005 by Herbert Xu Committed by Arnaldo Carvalho de Melo Oct 20, 2005

[DCCP]: Use skb_set_owner_w in dccp_transmit_skb when skb->sk is NULL



David S. Miller <davem@davemloft.net> wrote:
> One thing you can probably do for this bug is to mark data packets
> explicitly somehow, perhaps in the SKB control block DCCP already
> uses for other data.  Put some boolean in there, set it true for
> data packets.  Then change the test in dccp_transmit_skb() as
> appropriate to test the boolean flag instead of "skb_cloned(skb)".

I agree.  In fact we already have that flag, it's called skb->sk.
So here is patch to test that instead of skb_cloned().

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Ian McDonald <imcdnzl@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

parent ac9b9c66

net/dccp/output.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -62,10 +62,8 @@ int dccp_transmit_skb(struct sock sk, struct sk_buff skb)

		skb->h.raw = skb_push(skb, dccp_header_size);
		dh = dccp_hdr(skb);
		/*
		* Data packets are not cloned as they are never retransmitted
		*/
		if (skb_cloned(skb))

		if (!skb->sk)
		skb_set_owner_w(skb, sk);

		/* Build DCCP header and checksum it. */

Admin message