net: sched: check for frozen queue before skb_bad_txq check (fd8e8d1a) · Commits · 戴 / test

I can not think of any reason to pull the bad txq skb off the qdisc if the txq we plan to send this on is still frozen. So check for frozen queue first and abort before dequeuing either skb_bad_txq skb or normal qdisc dequeue() skb. Signed-off-by:

John Fastabend <john.fastabend@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

net/sched/sch_generic.c

+7 −4

Original line number	Diff line number	Diff line
		@@ -204,7 +204,7 @@ static struct sk_buff dequeue_skb(struct Qdisc q, bool *validate,
		int *packets)
		{
		const struct netdev_queue *txq = q->dev_queue;
		struct sk_buff *skb;
		struct sk_buff *skb = NULL;

		*packets = 1;
		if (unlikely(!skb_queue_empty(&q->gso_skb))) {
		@@ -248,11 +248,14 @@ static struct sk_buff dequeue_skb(struct Qdisc q, bool *validate,
		}
		validate:
		*validate = true;

		if ((q->flags & TCQ_F_ONETXQUEUE) &&
		netif_xmit_frozen_or_stopped(txq))
		return skb;

		skb = qdisc_dequeue_skb_bad_txq(q);
		if (unlikely(skb))
		goto bulk;
		if (!(q->flags & TCQ_F_ONETXQUEUE) \|\|
		!netif_xmit_frozen_or_stopped(txq))
		skb = q->dequeue(q);
		if (skb) {
		bulk:

Admin message