Commit fd8d26ad authored May 16, 2018 by Dan Carpenter Committed by Vinod Koul May 17, 2018

dmaengine: sprd: fix an NULL vs IS_ERR() bug



We recently cleaned this code up but we need to update the error
handling as well.  The devm_ioremap_resource() returns error pointers on
error, never NULL.

Fixes: e7f063ae ("dmaengine: sprd: Use devm_ioremap_resource() to map memory")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent e7f063ae

drivers/dma/sprd-dma.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -808,8 +808,8 @@ static int sprd_dma_probe(struct platform_device *pdev)

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		sdev->glb_base = devm_ioremap_resource(&pdev->dev, res);
		if (!sdev->glb_base)
		return -ENOMEM;
		if (IS_ERR(sdev->glb_base))
		return PTR_ERR(sdev->glb_base);

		dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask);
		sdev->total_chns = chn_count;

Admin message