Commit fd7f6727 authored Jan 18, 2016 by Jean Delvare Committed by Herbert Xu Jan 19, 2016

crypto: crc32c - Fix crc32c soft dependency



I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.

OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)

Cc: stable@vger.kernel.org
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 4f0414e5

crypto/crc32c_generic.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -172,4 +172,3 @@ MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations wrapper for lib/crc32c");
		MODULE_LICENSE("GPL");
		MODULE_ALIAS_CRYPTO("crc32c");
		MODULE_ALIAS_CRYPTO("crc32c-generic");
		MODULE_SOFTDEP("pre: crc32c");

lib/libcrc32c.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -74,3 +74,4 @@ module_exit(libcrc32c_mod_fini);
		MODULE_AUTHOR("Clay Haapala <chaapala@cisco.com>");
		MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
		MODULE_LICENSE("GPL");
		MODULE_SOFTDEP("pre: crc32c");

Admin message