Commit fd7048ad authored Oct 23, 2017 by Mark Rutland Committed by Ingo Molnar Oct 25, 2017

locking/atomics, fs/ncpfs: Convert ACCESS_ONCE() to READ_ONCE()/WRITE_ONCE()



The NCPFS code has some stale comments regarding ACCESS_ONCE() uses
which were removed a long time ago.

Let's remove the stale comments.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Petr Vandrovec <petr@vandrovec.name>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: davem@davemloft.net
Cc: linux-arch@vger.kernel.org
Cc: mpe@ellerman.id.au
Cc: shuah@kernel.org
Cc: snitzer@redhat.com
Cc: thor.thayer@linux.intel.com
Cc: tj@kernel.org
Cc: will.deacon@arm.com
Link: http://lkml.kernel.org/r/1508792849-3115-5-git-send-email-paulmck@linux.vnet.ibm.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 66702eb5

fs/ncpfs/dir.c

+0 −9

Original line number	Diff line number	Diff line
		@@ -119,10 +119,6 @@ static inline int ncp_case_sensitive(const struct inode *i)
		/*
		* Note: leave the hash unchanged if the directory
		* is case-sensitive.
		*
		* Accessing the parent inode can be racy under RCU pathwalking.
		* Use ACCESS_ONCE() to make sure we use _one_ particular inode,
		* the callers will handle races.
		*/
		static int
		ncp_hash_dentry(const struct dentry dentry, struct qstr this)
		@@ -147,11 +143,6 @@ ncp_hash_dentry(const struct dentry dentry, struct qstr this)
		return 0;
		}

		/*
		* Accessing the parent inode can be racy under RCU pathwalking.
		* Use ACCESS_ONCE() to make sure we use _one_ particular inode,
		* the callers will handle races.
		*/
		static int
		ncp_compare_dentry(const struct dentry *dentry,
		unsigned int len, const char str, const struct qstr name)

Admin message