crypto: testmgr - check skcipher min_keysize (fd60f727) · Commits · 戴 / test

When checking two implementations of the same skcipher algorithm for consistency, require that the minimum key size be the same, not just the maximum key size. There's no good reason to allow different minimum key sizes. Signed-off-by:

Eric Biggers <ebiggers@google.com> Signed-off-by:

Herbert Xu <herbert@gondor.apana.org.au>

crypto/testmgr.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -2764,6 +2764,15 @@ static int test_skcipher_vs_generic_impl(const char *driver,

		/* Check the algorithm properties for consistency. */

		if (crypto_skcipher_min_keysize(tfm) !=
		crypto_skcipher_min_keysize(generic_tfm)) {
		pr_err("alg: skcipher: min keysize for %s (%u) doesn't match generic impl (%u)\n",
		driver, crypto_skcipher_min_keysize(tfm),
		crypto_skcipher_min_keysize(generic_tfm));
		err = -EINVAL;
		goto out;
		}

		if (maxkeysize != crypto_skcipher_max_keysize(generic_tfm)) {
		pr_err("alg: skcipher: max keysize for %s (%u) doesn't match generic impl (%u)\n",
		driver, maxkeysize,

Admin message