Commit fd5f7cde authored Jan 16, 2018 by Sergey Senozhatsky Committed by Petr Mladek Jan 16, 2018

printk: Never set console_may_schedule in console_trylock()

This patch, basically, reverts commit 6b97a20d ("printk:
set may_schedule for some of console_trylock() callers").
That commit was a mistake, it introduced a big dependency
on the scheduler, by enabling preemption under console_sem
in printk()->console_unlock() path, which is rather too
critical. The patch did not significantly reduce the
possibilities of printk() lockups, but made it possible to
stall printk(), as has been reported by Tetsuo Handa [1].

Another issues is that preemption under console_sem also
messes up with Steven Rostedt's hand off scheme, by making
it possible to sleep with console_sem both in console_unlock()
and in vprintk_emit(), after acquiring the console_sem
ownership (anywhere between printk_safe_exit_irqrestore() in
console_trylock_spinning() and printk_safe_enter_irqsave()
in console_unlock()). This makes hand off less likely and,
at the same time, may result in a significant amount of
pending logbuf messages. Preempted console_sem owner makes
it impossible for other CPUs to emit logbuf messages, but
does not make it impossible for other CPUs to append new
messages to the logbuf.

Reinstate the old behavior and make printk() non-preemptible.
Should any printk() lockup reports arrive they must be handled
in a different way.

[1] http://lkml.kernel.org/r/201603022101.CAH73907.OVOOMFHFFtQJSL%20()%20I-love%20!%20SAKURA%20!%20ne%20!%20jp
Fixes: 6b97a20d ("printk: set may_schedule for some of console_trylock() callers")
Link: http://lkml.kernel.org/r/20180116044716.GE6607@jagdpanzerIV


To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: akpm@linux-foundation.org
Cc: linux-mm@kvack.org
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>

parent c162d5b4

kernel/printk/printk.c

+8 −14

Original line number	Original line	Diff line number	Diff line
	@@ -1888,6 +1888,12 @@ asmlinkage int vprintk_emit(int facility, int level,

	/* If called from the scheduler, we can not call up(). */		/* If called from the scheduler, we can not call up(). */
	if (!in_sched) {		if (!in_sched) {
			/*
			* Disable preemption to avoid being preempted while holding
			* console_sem which would prevent anyone from printing to
			* console
			*/
			preempt_disable();
	/*		/*
	* Try to acquire and then immediately release the console		* Try to acquire and then immediately release the console
	* semaphore. The release will print out buffers and wake up		* semaphore. The release will print out buffers and wake up
	@@ -1895,6 +1901,7 @@ asmlinkage int vprintk_emit(int facility, int level,
	*/		*/
	if (console_trylock_spinning())		if (console_trylock_spinning())
	console_unlock();		console_unlock();
			preempt_enable();
	}		}

	return printed_len;		return printed_len;
	@@ -2211,20 +2218,7 @@ int console_trylock(void)
	return 0;		return 0;
	}		}
	console_locked = 1;		console_locked = 1;
	/*		console_may_schedule = 0;
	* When PREEMPT_COUNT disabled we can't reliably detect if it's
	* safe to schedule (e.g. calling printk while holding a spin_lock),
	* because preempt_disable()/preempt_enable() are just barriers there
	* and preempt_count() is always 0.
	*
	* RCU read sections have a separate preemption counter when
	* PREEMPT_RCU enabled thus we must take extra care and check
	* rcu_preempt_depth(), otherwise RCU read sections modify
	* preempt_count().
	*/
	console_may_schedule = !oops_in_progress &&
	preemptible() &&
	!rcu_preempt_depth();
	return 1;		return 1;
	}		}
	EXPORT_SYMBOL(console_trylock);		EXPORT_SYMBOL(console_trylock);

Admin message