Commit fd5d7819 authored Apr 23, 2020 by Kai-Heng Feng Committed by Kalle Valo May 06, 2020

rtw88: Use udelay instead of usleep in atomic context

It's incorrect to use usleep in atomic context.

Switch to a macro which uses udelay instead of usleep to prevent the issue.

Fixes: 6343a6d4 ("rtw88: Add delay on polling h2c command status bit")
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200423073007.3566-1-kai.heng.feng@canonical.com

parent 57a29df3

drivers/net/wireless/realtek/rtw88/fw.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -228,9 +228,9 @@ static void rtw_fw_send_h2c_command(struct rtw_dev *rtwdev,
		goto out;
		}

		ret = read_poll_timeout(rtw_read8, box_state,
		!((box_state >> box) & 0x1), 100, 3000, false,
		rtwdev, REG_HMETFR);
		ret = read_poll_timeout_atomic(rtw_read8, box_state,
		!((box_state >> box) & 0x1), 100, 3000,
		false, rtwdev, REG_HMETFR);

		if (ret) {
		rtw_err(rtwdev, "failed to send h2c command\n");