Commit fd51bcc5 authored Aug 28, 2007 by Samuel Committed by Russell King Aug 28, 2007

[ARM] 4557/1: Fix PXA irq gpio initialization



As pointed out by Jrgen, we are overflowing the number of GPIOs
in pxa_init_irq_gpio(). I'm seeing the same problem on my HTC
Universal PXA270 based PDA.
According to Eric, the function argument is the number of GPIOs,
so we should keep the semantics and reduce the number of
iteration by 1.

Signed-off-by: Samuel Ortiz <sameo@openedhand.com>
Acked-by: Jrgen Schindele <linux@schindele.name>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

parent d555dd50

arch/arm/mach-pxa/irq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -365,7 +365,7 @@ void __init pxa_init_irq_gpio(int gpio_nr)
		set_irq_flags(irq, IRQF_VALID \| IRQF_PROBE);
		}

		for (irq = IRQ_GPIO(2); irq <= IRQ_GPIO(gpio_nr); irq++) {
		for (irq = IRQ_GPIO(2); irq < IRQ_GPIO(gpio_nr); irq++) {
		set_irq_chip(irq, &pxa_muxed_gpio_chip);
		set_irq_handler(irq, handle_edge_irq);
		set_irq_flags(irq, IRQF_VALID \| IRQF_PROBE);

Admin message